Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

S3 file upload cloud formation setup #35

Open
1 task done
emettely opened this issue Jun 25, 2019 · 6 comments
Open
1 task done

S3 file upload cloud formation setup #35

emettely opened this issue Jun 25, 2019 · 6 comments
Assignees
Labels
enhancement New feature or request

Comments

@emettely
Copy link
Contributor

emettely commented Jun 25, 2019

Context

We want to upload directly to S3 from the client using the signed URL.

Acceptance Criteria

  • Set up S3 in Cloudformation and deploy in Cosmos (infrastructure repository)

-Make sure upload of files are only done through signed URLs, retrieved from the API-
(moved to a different ticket)

Some useful references

@emettely
Copy link
Contributor Author

I'm setting up the S3 as part of the API.

@emettely
Copy link
Contributor Author

emettely commented Jun 26, 2019

The S3 is setup for int and test bundled with the API. The permissions from the API is:

                                "s3:ListBucket",
                                "s3:*Object"

https://github.com/bbc/digital-paper-edit-infrastructure/blob/master/dpe-api/infrastructure/src/main.py

^ This is the bit that has that logic. @jamesdools and @pietrop , we might want to consider what the life-cycle (expire in 1 year or half a year...) of items in the bucket should be. I have it currently commented out - but once we figure out the subdirectory names (e.g. audio, original, preview etc.) we can uncomment + implement the lifecycle policy.

@jamesdools jamesdools moved this from Ready to start to In progress in BBC News Labs - (0) Digital Paper Edit - Sprint Board Jun 27, 2019
@pietrop
Copy link
Contributor

pietrop commented Jun 28, 2019

@emettely can you add some more details on how this works?

I get there's something added to the cloud formation to give the EC2 instance for the API serve the capability to access the bucket(?)

Do we know more about how do you then access (add or get files from the S3 bucket) from within the express server inside the API? (do we use the AWS Node SDK?)

Also I see the link goes straight into master, was there a PR for this?

And is this still in progress ready for review or done?

@pietrop pietrop changed the title S3 file upload (setup and integration) S3 file upload cloud formation setup Jun 28, 2019
@pietrop
Copy link
Contributor

pietrop commented Jun 28, 2019

narrowing down this card to be only covering first part of acceptance criteria to do with

  • Set up S3 in Cloudformation and deploy in Cosmos (infrastructure repository)

moving the rest to a separate card bbc/digital-paper-edit-api#4

@pietrop
Copy link
Contributor

pietrop commented Jun 28, 2019

To review this (draft)

  1. Use python script to generates cloud formation file
  2. Use Jenkins to upload to AWS (stack job)
  3. see if it gets picked up in int, test etc.. in cosmos
  4. in AWS console you should see the resources with right policies

@emettely
Copy link
Contributor Author

@jamesdools jamesdools moved this from Ready to review to Reviewer approved in BBC News Labs - (0) Digital Paper Edit - Sprint Board Jul 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
No open projects
Development

No branches or pull requests

3 participants