Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typescript conversion? #243

Open
jjeff opened this issue Jan 6, 2023 · 1 comment
Open

Typescript conversion? #243

jjeff opened this issue Jan 6, 2023 · 1 comment

Comments

@jjeff
Copy link

jjeff commented Jan 6, 2023

I see some discussion here about either providing an index.d.ts (Typescript typings) file along with VideoContext or, just converting the entire library to Typescript – which IMO would be more maintainable. However, I'm not a maintainer – and that issue has been closed.

I might have some energy to do a Typescript conversion. However, before I do this, I'd like to hear from a maintainer (someone at the @bbc?) about whether they'd be open to this change. I would try to keep things intact as much as possible, but all of the src/**/*.js files will become .ts files, so from a git perspective, it's a pretty major overhaul.

Luckily, with webpack, there's already a compilation workflow. So things wouldn't change much in terms of publishing workflow… (should VideoContext ever be published to npm again).

So before I dive in, what are the chances that this PR would land? @yakca?

@yakca
Copy link
Member

yakca commented Feb 15, 2023

@jjeff we're definitely still open to PRs and contributions to the project. TypeScript has gained significant momentum over the years since that previous issue was raised, so I'd be happy to merge something like this to main branch pending the usual linting and tests requirements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants