Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix broken source of aframe example video #180

Merged
merged 1 commit into from Oct 24, 2019
Merged

Fix broken source of aframe example video #180

merged 1 commit into from Oct 24, 2019

Conversation

yakca
Copy link
Member

@yakca yakca commented Oct 24, 2019

Fixes #178

@yakca yakca requested a review from richski October 24, 2019 14:12
richski
richski approved these changes Oct 24, 2019
View reviewed changes
Copy link
Contributor

@richski richski left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one! Weirdly Travis is reporting a successful build, but Github still thinks continuous-integration/travis-ci/pr is pending.

Also noticed the last build of develop failed, so I've triggered a rebuild. Probs best to hold off merging this until that passes.

@richski richski merged commit 12d429e into develop Oct 24, 2019
@richski richski deleted the fix_aframe_example_video branch October 24, 2019 20:04
@richski richski mentioned this pull request Oct 24, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richski richski richski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

A-frame demo not working
2 participants
@yakca @richski