Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should predicate-like kw args end with questionmark #136

Closed
sbelak opened this issue Jul 12, 2016 · 2 comments
Closed

Should predicate-like kw args end with questionmark #136

sbelak opened this issue Jul 12, 2016 · 2 comments

Comments

@sbelak
Copy link

sbelak commented Jul 12, 2016

(foo {:fluffy? true} xs)

vs.

(foo {:fluffy true} xs)

clojure.core seems to adhere to the later (see spec/map-of, core.server/start-server), but a lot of libraries (random example https://github.com/ztellman/aleph/blob/f540bb101299448cd3f867f9b0172f5c12acd535/src/aleph/http.clj#L20) use the former.

@maxcountryman
Copy link

Aleph also uses boolean-containing vars formatted in this way.

(when fluffy? :aww)

I personally find this much easier to read.

@bbatsov
Copy link
Owner

bbatsov commented Dec 5, 2020

I'll close this ticket in favour of #182, that generated a bigger conversation on the subject.

@bbatsov bbatsov closed this as completed Dec 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants