-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Queries with union and uses wrong binding parameters (in some cases) #1602
Comments
Hi Erik,
Thanks for responding so quickly.
barryvdh/laravel-debugbar: v3.6.7
laravel/framework: v8.83.14
Kindest Regards / Met vriendelijke groet,
Machlon Laarman
Van: erikn69 ***@***.***>
Verzonden: dinsdag 2 april 2024 17:55
Aan: barryvdh/laravel-debugbar ***@***.***>
CC: machlon-caveo-nl ***@***.***>; Author ***@***.***>
Onderwerp: Re: [barryvdh/laravel-debugbar] Queries with union and uses wrong binding parameters (in some cases) (Issue #1602)
image.png (view on web) <https://github.com/barryvdh/laravel-debugbar/assets/4933954/13c29e72-99cc-45e0-aad7-428e9e25ec39>
I couldn't replicate it, what driver do you use, Laravel version, laravel-debugbar version?
—
Reply to this email directly, view it on GitHub <#1602 (comment)> , or unsubscribe <https://github.com/notifications/unsubscribe-auth/AZLVB4U3OATMIAB4XROYL4TY3LIEHAVCNFSM6AAAAABFTKK3O6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMZSGQZTQMZYGY> .
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
You have very really outdated versions "require-dev": {
"barryvdh/laravel-debugbar": "^3.6.7",
///
},
"repositories":[
{
"type": "vcs",
"url": "[email protected]:erikn69/laravel-debugbar.git"
}
], Then |
Hi Erik,
I tried your patch but still the same result.
It’s not a big deal but maybe the problem is still present in master branch.
Thanks anyway
Met vriendelijke groet,
Machlon Laarman
Van: erikn69 ***@***.***>
Verzonden: woensdag 3 april 2024 16:16
Aan: barryvdh/laravel-debugbar ***@***.***>
CC: machlon-caveo-nl ***@***.***>; Author ***@***.***>
Onderwerp: Re: [barryvdh/laravel-debugbar] Queries with union and uses wrong binding parameters (in some cases) (Issue #1602)
You have very really outdated versions
try adding "repositories" with my fork, i added laravel 8 with the current changes
"require-dev": {
"barryvdh/laravel-debugbar": "^3.6.7",
///
},
"repositories":[
{
"type": "vcs",
"url": ***@***.***:erikn69/laravel-debugbar.git"
}
],
—
Reply to this email directly, view it on GitHub <#1602 (comment)> , or unsubscribe <https://github.com/notifications/unsubscribe-auth/AZLVB4SXXKTBOIILYAXPWE3Y3QFK3AVCNFSM6AAAAABFTKK3O6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMZUG42DGMJWHA> .
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I was investigating a query and found this:
Main Query (with 2 binding params) keys [0, 1]
Union Query (with 3 binding params) keys [2, 3, 4]
Debug bar uses [0, 1] for Main and [0, 1, 2] for Union query
In this case the sql is rendered incorrect
The text was updated successfully, but these errors were encountered: