-
-
Notifications
You must be signed in to change notification settings - Fork 110
Will this wrapper support professional API? Cannot find a way to use my api key #47
Comments
I don't think this has been looked into yet. I'll check out what would be needed to make the conversion. As of now, this is not supported. Edit: I've also opened a pull request that should help with the rate limiting handling... It hasn't been touched in a while though. I gave it a bump today. |
Ohai, haven't found the time to update yet, I'll try my best to do so before the deadline. Cheers. |
The API key is the least of our worries. Most of the API calls are different now, and will require different requests and response handlers. I've been messing around with it the last hour, the API key only requires 3 lines of code, but practically everything else in the listings and ticker functions are going to require changes. Haven't even looked at stats yet. |
@dahifi I'll take some time this weekend to look at refactoring the code for the new calls. |
CoinMarketCap are discontinuing the v2 API on 04.12.18 btw: |
If you guys are looking for a public open API for market data and more, do consider our API at https://www.coingecko.com/api |
It seems to be working but probably not for long. |
Any idea if this will be updated to be able to use the new APIs? I don't want to lose the functionality of my setup. Owner, not sure if you are reading this, but will you continue to maintain this library? You are in a very priviledged position of having the default library when doing the pip install coinmarketcap. |
I updated the functions to use the new API on my own fork. Right now I have the wrapper using the sandbox API on one branch, but will update it to use the pro version later tonight or tomorrow. See here for the sandbox branch: https://github.com/kodycode/coinmarketcap/tree/sandbox_branch It requires an UPDATE: @barnumbirr I made a PR, let me know if this gets things up to speed. |
@kodycode will your pr require changes from a users perspective, or would an existing implementation continue to work as is? |
@xmatthias Yes, it would require changes from a users perspective. The first change of this updated implementation you would need to supply an api key as one of the arguments for creating the There are also new arguments to feed to the endpoints if so desired. I've documented them in the comments of these functions in my branch, but you may also read them up on the links I posted as well. |
As of 5 March 2020 the public API has been taken down. The module is no longer working. I used this with Home Assistant and its no longer working. Any chance that the code will be updated to use the pro api? What's the status of merging PR #51 ? |
The wrapper seems to be working fine without one, but I don't want to get my IP rate limited. In the future I may have to purchase one of the paid api plans to avoid getting limited.
I have looked around and couldn't find where am I supposed to type my api key.
EDIT: I found out why, this wrapper is still using the public API v2. From coinexchange api documentation:
The text was updated successfully, but these errors were encountered: