-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initialization error in Step 7 #75
Labels
Comments
@Bob-McCrory Yes, you're right. Thanks for pointing this out! There are two ways to fix it, depending on what
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I believe the initialization in the Step 7 diffuse() function is incomplete: Only the nodes with an initial value of 2 are reset; all other nodes are left as they were after the last call to diffuse(). For example, if you run diffuse(10) twice in succession and look at statistics such as the maximum and minimum value of u, you will see that the results differ in the two runs. This occurs because the initial values outside of [0.5, 1.0], [0.5, 1.0] have not been reset to 1.0.
This can be remedied by adding "u = numpy.ones((ny, nx)) as the first statement in diffuse().
Thanks for putting these steps to CFD together; they have been very helpful to me. I hope this is a little helpful for you.
Bob
The text was updated successfully, but these errors were encountered: