Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for ic_launcher_round #197

Closed
iotashan opened this issue Sep 6, 2018 · 5 comments
Closed

Support for ic_launcher_round #197

iotashan opened this issue Sep 6, 2018 · 5 comments

Comments

@iotashan
Copy link

iotashan commented Sep 6, 2018

RN 0.57.0 adds a new icon to the default android project, ic_launcher_round.

image

image

It would be great if rn-toolbox:assets was updated to support generating this image, too. It might need a separate source that the normal icon, given how much a circle cuts off.

@roysG
Copy link

roysG commented Feb 19, 2019

Any update?

@vdelacou
Copy link

#216 Just submit a pull request

@schumannd
Copy link

Maybe the readme in generator-rn-toolbox/generators/assets/README.md should also be updated as it currently suggests generating the android launcher icon through android studio

@c1ngular
Copy link

@schumannd good point , though i found that icons generated by the android studio way , has better resolution , better picture quality on my test device .

@yleflour
Copy link

yleflour commented Sep 5, 2019

Hello, we just revamped the generator 😁

For up to date icon and splashscreen generation please use @bam.tech/react-native-make

The new version generates Android adaptive icons, so it should solve your issue as long as the input image follows adaptive icons guidelines😉

@yleflour yleflour closed this as completed Sep 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants