Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rounded icons on Android #181

Closed
tommycarpi opened this issue Jun 6, 2018 · 9 comments
Closed

Rounded icons on Android #181

tommycarpi opened this issue Jun 6, 2018 · 9 comments

Comments

@tommycarpi
Copy link

Is it possible to have the icons for Android rounded, rather than squared?
I have no physical device to test it on, but on the Android Studio emulator I got all default apps rounded, and mine squared 👯 .

P.s. the icon I'm using is squared.

@roysG
Copy link

roysG commented Jun 6, 2018

+1

@song50119
Copy link

song50119 commented Jun 10, 2018

For each platform I just put --ios/--android like this
yo rn-toolbox:assets --icon square_ios.png --ios
yo rn-toolbox:assets --icon round_android.png --android
😀

@kenshinman
Copy link

Why not just make it rounded already in the design and export use png instead

@wregis
Copy link

wregis commented Aug 8, 2018

I see little need for creating a new round image automatically, maybe a parameter that will output with a different filename (--anddrod-round) other that ic_launcher.png (e.g.: ic_launcher_round.png) or allow for a custom one (--filename).

@vdelacou
Copy link

#216 I just submit a pull request to automatically generate the ic_launcher_round.png

@guillermoroblesjr
Copy link

As a temporary work around you can use @vdelacou pull request which works great!

sudo npm install -g "git://github.com/bamlab/generator-rn-toolbox.git#d10da2de"

@ThiagoAugustoSM
Copy link

I just used @guilhermebruzzi snippet and @vdelacou code to solve the problem. thanks guys

@yleflour
Copy link

yleflour commented Sep 5, 2019

Hello, we just revamped the generator 😁

For up to date icon and splashscreen generation please use @bam.tech/react-native-make

The new version generates Android adaptive icons, so it should solve your issue 😉

@yleflour yleflour closed this as completed Sep 5, 2019
@comp-phys-marc
Copy link

I can confirm that #216 works great. Hopefully it is merged soon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

10 participants