-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Error: cannot find file .npmignore #20
Comments
Hmm, if that is the case, it should not throw an exception there. Care to fix this and submit a pull request? I promise to merge it quickly. |
This looks like a important PR. Shall I contribute to it ? |
What do you suggest we do about this ? |
Thank you for looking at this. I would make a list of optional filenames with |
@bahmutov Yeah, makes sense. I will look into it and see what other files are optional in now deployment. |
I too am experiencing this issue for some reason. Is this due to an incorrect configuration on my end or is this affecting everyone? |
This is a weird issue and I do not completely understand when and why it happens. Might be because I use |
Can you run the tool with |
From CI? |
that's where it happens? sure on CI you can either set an environment variable or just update your CI file command, something like
|
It happens both locally and from ci. from debug:
|
I don't have a .npmignore file in my repo, so is now-pipeline adding that somewhere? I see it in the file array. |
no, this list comes from Do you want to fix this (I think it should be done like #20 (comment)) ? A pull request with the fix would be greatly appreciated. |
Yes I will try to get a PR up within the hour. I've traced the requirement back to here: It would seem that pkgd is just pulling that entire list and using that as it's requirements. I'm trying to figure out the best way to alter that. |
@wulfmann Woah |
@wulfmann just have our own "optional" list? |
@bahmutov That's a big question to ask. But first, we need to check what now.sh considers optional, since if we don't include that, now.sh is gonna throw errors |
For now, we can just keep |
Yea that should work. I have an idea on how to add an optional list, just making sure I fully understand everything that’s going on. |
Though this is hardly a fix, adding an empty .npmignore resolves the issue. I'm working on a fork to retool the whole file-checking section since there are a few different rules as to which file / property takes precedence. I put the loop of 'readFileSync' of the filenames in a try catch instead and that allowed the function to continue without the presence of the .npmignore, but threw a 500 server error at the very end. I need to try it with the correct keys but I still think it's an error somewhere else. I'll keep you guys updated but it will probably take me a few days to get to it. If you have any suggestions i'd love to hear them. This is a great module so I really want to contribute and continue using it. |
I'm experiencing this issue as well, debug output here: https://gist.github.com/anonymous/4a5a337b210c4ecf8084652a83385a34 Do I create a |
Apologies that I never got back to this. I've opened a PR with a simple change that should solve the issue. |
@spences10 My changes were merged. Whenever the npm package is updated could you check and see if you are still experiencing that issue? I'm working on recreating the issue i had with it back in August to make sure it's all set, but it will likely be confirmed sooner by you. |
ok, published as 1.9.0 |
I'll get on this shortly. I'll take out the Thanks @wulfmann 👍 |
Trying to use now-pipeline and get:
per now doc (https://zeit.co/docs/features/now-cli#selecting-files-and-directories-to-be-uploaded) .npmignore file is optional. Please advise.
The text was updated successfully, but these errors were encountered: