Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter by Collection -> 'Latest' is twice in the list. #171

Closed
unholyeyebrows opened this issue Dec 10, 2024 · 6 comments · Fixed by #172
Closed

Filter by Collection -> 'Latest' is twice in the list. #171

unholyeyebrows opened this issue Dec 10, 2024 · 6 comments · Fixed by #172

Comments

@unholyeyebrows
Copy link

Hi

On Windows x64, I am seeing the 'Latest' option shown twice in the 'Filter by Collection' menu. I have uninstalled and re-installed but this has not solved it.

Prob,em seen in stand-alone app as well as the VST and CLAP plugins. See attached screenshot.

Thanks
Nick
Screenshot 2024-12-10 134015

@baconpaul
Copy link
Owner

Thanks

my guess is @airwindows has a trailing space in the pedia somewhere and my parser is not stripping it. I’ll take a peek after the weekend

@airwindows
Copy link
Collaborator

I think I found it. You can adjust your parser if you like but I adjusted what.txt so it will probably go away again…

Cans used [Latest,Recommended] but everything else was in the form of [Recommended,Latest]. I think that must be what did it: your parser assumed things would be in an expected order, and an instance came in where the order was reversed, which seems to have forced it into a distinct category? At least, that's what I observed, and it's a recent 'bug'. If you like, see if the parser is sensitive to the order of the categories as read, because that was a departure from all other instances of 'Latest', and it was only order, not a trailing space.

@baconpaul
Copy link
Owner

ahh ok well it will get fixed on Sunday then, but lets leave this open and I can figure out why the parser failed there. It really shouldn't. Do you have the commit where you fix the pedia so i can backtrack and adjust one day?

@baconpaul
Copy link
Owner

and thanks!

@airwindows
Copy link
Collaborator

I have not yet committed a fix, so it should still have the behavior. The fix will happen (unless you'd rather it didn't!) this weekend, on Saturday most likely when I push a 240 plate and include it in what.txt etc. Until that push, things are as they were with the two 'Latest's.

@baconpaul
Copy link
Owner

Found it. We weren't stripping leading spaces. That first category was " Leading"

Fix inbound.

baconpaul added a commit that referenced this issue Dec 14, 2024
which lead to "latest" appearing twice

Also upgrade CPM to latest

Closes #171
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants