-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Line highlighting in codeblocks has changed #183
Comments
Here too. Please fix. Thanks. |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I have recently just upgraded mkdocs-techdocs-core from v1.2.3 -> v1.3.5 and have been testing on my documentation smoke test page and noticed a significant change in how codeblock highlighting is visualized using the
hl_lines
directive.Version 1.2.3
![image](https://private-user-images.githubusercontent.com/16994570/319660504-fda7ba19-2a92-4d06-91b9-29e29e4cc367.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTg5NTg2NDYsIm5iZiI6MTcxODk1ODM0NiwicGF0aCI6Ii8xNjk5NDU3MC8zMTk2NjA1MDQtZmRhN2JhMTktMmE5Mi00ZDA2LTkxYjktMjllMjllNGNjMzY3LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA2MjElMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNjIxVDA4MjU0NlomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWU5YWRjYmM2MzIzYzE5NzczOTUyZDgzYjUxYTIwN2I0NjUwNjc3MWZhMmU4YjA3MDM0ZDU0MTNiNzdjNWJlYzcmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.B4A5OxA1Fk9YqyXXJBhDXPJoYFfukdVhnOol3YVTL1E)
Version ^1.3.3
![image](https://private-user-images.githubusercontent.com/16994570/319660793-4a12f273-4d19-4299-84c5-ed2a40f652ff.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTg5NTg2NDYsIm5iZiI6MTcxODk1ODM0NiwicGF0aCI6Ii8xNjk5NDU3MC8zMTk2NjA3OTMtNGExMmYyNzMtNGQxOS00Mjk5LTg0YzUtZWQyYTQwZjY1MmZmLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA2MjElMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNjIxVDA4MjU0NlomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTA0ZmIxYTkwYTBlMGFhNjFmNzlhOGMyMWE0NTQ2MjBjNWZkNjgyNGI5ZGUxNGMzM2JkN2ZhYjZiM2NjODdkNzMmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.8j3Bl-oX-lIaHBoaSeoxNjIUNPSGAxFYtNMb8DVZZoA)
I'm not sure if this was an intentional style change or is a bug, but the new way that line highlighting works is too subtle and easy to miss.
I've done some testing of versions in between and this seems to have been introduced in
[email protected]
, which bumpedmkdocs-material
to 9.4.14Looking at the css of the
.hll
and.highlight
CSS class, it looks like thebackground-color
was updated:Old:
background-color: var(--md-code-hl-color)
New:
background-color: var(--md-code-hl-color--light)
This seems to have been changed in mkdocs-material as reported in squidfunk/mkdocs-material#6017
The text was updated successfully, but these errors were encountered: