Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

babel-plugin-minify-dead-code-elimination fails to remove variable declaration after return statement #1020

Open
fengzilong opened this issue Oct 14, 2021 · 0 comments

Comments

@fengzilong
Copy link

fengzilong commented Oct 14, 2021

Describe the bug

As described in title

To Reproduce

Minimal code to reproduce the bug

function foo() {
  if ( true ) {
    return
  }

  const timer = setInterval(
    () => { console.log( timer ) }, 1000
  )
}

Actual Output

there is no Error thrown

function foo() {
  var timer = setInterval(function () {
    console.log(timer);
  }, 1000);
}

Expected Output

function foo() {}

Possible solution

If the timer reference doesn't appeared before return in current scope, it can be safely removed

Additional context

Here is the Babel REPL link to reproduce

@fengzilong fengzilong changed the title babel-plugin-minify-dead-code-elimination fails to remove const variable declaration babel-plugin-minify-dead-code-elimination fails to remove variable declaration after return statement Oct 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant