Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup NodePath methods #16443

Open
nicolo-ribaudo opened this issue Apr 24, 2024 · 0 comments
Open

Cleanup NodePath methods #16443

nicolo-ribaudo opened this issue Apr 24, 2024 · 0 comments
Milestone

Comments

@nicolo-ribaudo
Copy link
Member

There are a lot of methods on NodePath that aren't really meant to be public -- it's just that we expose all the function exported by the internal files that implement the various NodePath actually-public methods.

We should go through all of them and only expose those that are actually used outside of @babel/traverse, ideally with an explicit list rather than doing

Object.assign(
NodePath_Final.prototype,
NodePath_ancestry,
NodePath_inference,
NodePath_replacement,
NodePath_evaluation,
NodePath_conversion,
NodePath_introspection,
NodePath_context,
NodePath_removal,
NodePath_modification,
NodePath_family,
NodePath_comments,
);

@nicolo-ribaudo nicolo-ribaudo added this to the v8.0.0 milestone Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant