New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Function 'finally' on prototype shouldn't polyfill 'promise' #96
Comments
I think we can skip the MemberExpression path if the it is in the babel-polyfills/packages/babel-helper-define-polyfill-provider/src/visitors/usage.js Line 27 in 615e5cd
|
It would work, even if somewhere that I wonder why we add the polyfill for function Test() {}
Test.prototype.finally = function() {} but not for Test.prototype.finally = function() {} |
It will break the monkey patching of built-in methods in some cases, for example testing. |
When i define a 'finally' function on other function's prototype, why dist code includes "core-js/modules/es.promise.finally.js",
"core-js/modules/es.promise.js".
ex:
The text was updated successfully, but these errors were encountered: