Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extraneous double quotes at end of posted comment on issues #63

Open
serhalp opened this issue Dec 16, 2020 · 2 comments
Open

extraneous double quotes at end of posted comment on issues #63

serhalp opened this issue Dec 16, 2020 · 2 comments

Comments

@serhalp
Copy link

serhalp commented Dec 16, 2020

babel-bot posted a comment on my issue here: babel/babel#12513 (comment). It contains an extraneous " at the very end:

[...] for an invite."

I traced through the code and I don't see where it would be coming from, since the string looks fine here and it's passed around without manipulation all the way to the GitHub API request. 🤷🏼

@serhalp
Copy link
Author

serhalp commented Dec 16, 2020

I can't believe I just painstakingly binary searched thousands of issues for a silly extraneous character in this mildly important bot's automated message, but:

I could get closer but I think that's probably good enough.

Interestingly, no commits around that time, so I dunno. Maybe a GitHub API change around then.

@nicolo-ribaudo
Copy link
Member

nicolo-ribaudo commented Dec 16, 2020

Oh thanks!

It's a bug here, would you like to open a PR? https://github.com/babel/babel/blob/main/.github/workflows/issue-triage.yml

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants