Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Effects to track for Combat Replay #651

Open
EliphasNUIT opened this issue Jul 8, 2022 · 5 comments
Open

Effects to track for Combat Replay #651

EliphasNUIT opened this issue Jul 8, 2022 · 5 comments
Assignees
Labels
enhancement New feature or request

Comments

@EliphasNUIT
Copy link
Collaborator

EliphasNUIT commented Jul 8, 2022

Work in Progress.

General

  • Portal positions (mesmer, scourge, etc)

Spirit Vale

  • Vale Guardian
    • greens
    • blues
    • arena parts that light up
  • Gorseval
    • yellow orbs to collect to lose debuff stacks
    • egg AoEs
    • blue debuff orb fields
  • Sabetha
    • cannon AoEs
    • debris AoEs
    • Flame puddles

Salvation Pass

  • Slothasor
    • Dropped Poisons.
  • Bandit Trio
    • Zane's blinding AoE
    • Flame puddles
    • Mortar AoEs (could also be used as mortars failed mechanic)
  • Matthias
    • Cleaner display of when a fountain is available/corrupted
    • Shard AoEs

Stronghold of the Faithful

  • Keep Construct
    • CM arena
    • debris AoEs
    • Cleaner display for the rotating blades
  • Twisted Castle
    • Nothing comes to mind
  • Xera
    • arena parts that light up
    • shield dome
    • xera's wipe attack

Bastion of the Penitent:

  • Cairn
    • Greens: partially done
    • TP AoEs
  • Mursaat Overseer
    • Spears
  • Samarog
    • Guldhem's stun AoE
  • Deimos
    • Proper black detection?

Hall of Chains

  • Soulless Horror
    • AA AoEs
  • River
  • Broken King
    • Greens
    • Icy Veins
  • Soul Eater
    • Spider Webs
    • AoEs during breakbar
  • Eyes
  • Dhuum
    • Veins
    • Cleaner green detection (today it is time + NPC location based)

Mythwright Gambit

  • Conjured Amalgamate
    • debris AoEs
  • Twin Largos
  • Qadim
    • Bouncy fireballs
    • Fiery AoEs

The Key of Ahdashim

  • Adina
    • Pillars
    • Destroyed platforms (for CM)
    • Indicators for platforms getting destroyed between phases
  • Sabir
    • Safe circles
  • Qadim the Fabulous
    • Yellow orbs to collect in CM for Gigantamax Qadim
    • Investigate sharks

Nightmare CM

  • MAMA
  • Siax
  • Ensolyss

Shaterred Observatory CM

  • Skorvald
  • Artsariiv
    • Green
    • Bouncy orb
  • Arkk
    • Green
    • Platforms getting destroyed

Sunqua Peak CM
TBC

Icebrood Construct
Should we even bother with this?

Fraenir of Jormag
TBC

Super Kodan Brothers
TBC

Boneskinner

Whisper of Jormag
TBC

@EliphasNUIT EliphasNUIT self-assigned this Jul 8, 2022
@EliphasNUIT EliphasNUIT added the enhancement New feature or request label Jul 8, 2022
@LunusLupus
Copy link
Contributor

LunusLupus commented Jul 9, 2022

Gorseval:

  • blue debuff orb fields
    KC:
  • Cleaner display for the rotating blades.
    SH:
    That auto attack pattern is insanely distributed with differently sized circles, I don't think that is worth the effort.
    Sabir:
  • Safe circles
    QtP:
    - All sharks, also the ones along the lines.

@EliphasNUIT
Copy link
Collaborator Author

I didn't go for "moving effects" like sharks on QtP because they'd need to be animated by hands. They are not associated to agents, the effects only come with initial position and an orientation. Simple stuff (like the bees in HT CM) are easy enough to animate by hand as they go only in one direction but depending on how the effects are distributed, sharks may require a high effort to animate.

@LunusLupus
Copy link
Contributor

True, I didn't think of the shark complexity.

Kaineng Overlook

  • red puddles dropped after numbers during main phases

@Sejsel
Copy link
Contributor

Sejsel commented Jul 11, 2022

I believe we could also use the effects in combination with movement of the numbered gadgets at Qadim to do real platform positions instead of emulated ones.

The gadgets were not always available because of an arcdps filter (they were added at the same time as banners), so removing the old implementation is likely not feasible without breaking support for older logs. There are some effects for the platforms, and they will likely allow us to see when the platforms get set on fire/broken.

@Linkaaaaa
Copy link
Contributor

Linkaaaaa commented Apr 22, 2023

If people wanna look into these:
Ankka:

  • Death's hand 1: 7c4ddd8f8f7e254c9016ea84f74daa5a
  • Death's hand 2: 176ad91c5bd7964188ac7e9930087c9d
  • Small aoes from ankka: 171a7bd24b5d0b4ba3770ff8a6a37ec0

Dhuum:

  • Swipe aoes: 91a23d51294e80458be9c3c89a2ed138
  • Swipe aoes2: c79f5d95e11070448a39acd7f6c5d0d3
  • Cracks expansion: f28528cbe08e0d43b3227a157cd1ccf2
  • Cracks explosion: 13b5022fbf7d884c9aa9ed667feec22f

And you can remove from your list because i've added them:

MAMA

  • Puddles
  • Shield

Siax

  • Puddles

Ensolyss

  • Arena getting smaller

Skorvald

  • Multi bounce attack with AoEs on the ground

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: In Progress
Development

No branches or pull requests

4 participants