Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typescript lint warnings in console #113

Open
travissouthard opened this issue Apr 17, 2023 · 1 comment
Open

Typescript lint warnings in console #113

travissouthard opened this issue Apr 17, 2023 · 1 comment
Labels
bug Something isn't working

Comments

@travissouthard
Copy link
Contributor

Overview

There are a lot of compile warnings in the logs and console of the demo right now.

Expected Behavior

We want to always have our React apps running with no errors or warnings, e.g. "Compiled successfully" every commit

Actual Behavior

There are many warnings. Most are "Unexpected any" and "Forbidden non-null assertion" and luckily the compiler tells us what files and line numbers to fix.

Steps to Reproduce

  • Go to the develop branch and run ./scripts/server
  • Once the app is running there will be a "Compiled with warnings." message and then all of the respective warnings

Demo

image

@travissouthard travissouthard added the bug Something isn't working label Apr 17, 2023
@jacobtylerwalls
Copy link
Contributor

Thanks, I forgot to open a card for this. We discussed it here:
#86 (comment)

Some of these are tolerable, so we could add a tslint ignore, but they need to be considered individually.

@jacobtylerwalls jacobtylerwalls changed the title React warnings in console Typescript lint warnings in console Apr 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants