Add continuous integration support via GitHub Actions #22
Conversation
| @@ -0,0 +1,6 @@ | |||
| version: 2 | |||
| updates: | |||
| - package-ecosystem: "github-actions" | |||
There was a problem hiding this comment.
This helps keep GitHub Actions up-to-date via Dependabot PRs.
| - name: Set up Scala ${{ matrix.jdk-version }} | ||
| uses: olafurpg/setup-scala@v10 | ||
| with: | ||
| java-version: ${{ matrix.jdk-version }} |
There was a problem hiding this comment.
It appears that Jabba is being used under the covers by this Action. If we want to test against additional JDK versions, we can add them to the jdk-version matrix list above.
|
|
||
| - name: Create new project from template | ||
| run: | | ||
| sbt new file://${GITHUB_WORKSPACE} \ |
There was a problem hiding this comment.
GITHUB_WORKSPACE here corresponds to the project directory checked out by actions/checkout.
| types: | ||
| - completed | ||
|
|
||
| jobs: |
There was a problem hiding this comment.
One of these is responsible for dependabot.yml initiated PRs and the other is for GitHub Security PRs.
| @@ -9,5 +9,5 @@ lazy val root = (project in file(".")) | |||
| val _ = (g8Test in Test).toTask("").value | |||
| }, | |||
| scriptedLaunchOpts ++= List("-Xms1024m", "-Xmx1024m", "-XX:ReservedCodeCacheSize=128m", "-Xss2m", "-Dfile.encoding=UTF-8"), | |||
| resolvers += Resolver.url("typesafe", url("http://repo.typesafe.com/typesafe/ivy-releases/"))(Resolver.ivyStylePatterns) | |||
| resolvers += Resolver.url("typesafe", url("https://repo.typesafe.com/typesafe/ivy-releases/"))(Resolver.ivyStylePatterns) | |||
There was a problem hiding this comment.
This was leading to connection refused errors during dependency resolution.
| @@ -34,8 +34,8 @@ | |||
|
|
|||
| set -o pipefail | |||
|
|
|||
| declare -r sbt_release_version="1.3.13" | |||
There was a problem hiding this comment.
All of the changes here are from pasting in the most up-to-date version of sbt-extras.
There was a problem hiding this comment.
Would it also make sense to copy this configuration into the project to create (under src/main/g8)? If people want to use a different CI, they can remove it, but if not we can include a note in the template setup about setting the appropriate secret in github
Before marking the PR ready for review, I went through the issue list and almost linked #1 to this PR as resolved. I ultimately didn't because it seemed like two different concerns: CI for the project template vs. CI for instances of the project template. I'm personally interested in resolving #1, but I think doing so in a separate PR makes sense since I think the testing cycle for it will be more involved. BTW, are you OK with me assigning you to review this PR? |
|
That makes sense to me and I'm happy to review this |
Exercise the project initializaotion process via continuous integration on every PR and merges to master. In addition: - Add support for keeping GitHub Actions up-to-date with Dependabot - Add support for automatically merging Dependabot PRs that pass CI - Add support for marking inactive issues as stale, and eventually closing them - Update `sbt-extras` script - Fix the Typesafe repository resolver
hectcastro
changed the title
hectcastro
force-pushed
the
hmc/github-actions
branch
from
dc75e32 to
298adc1
Compare
Exercise the project initialization process via continuous integration on every PR and merges to
master. In addition:sbt-extrasscriptTesting
Review the build output associated with this PR.