Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audit argument validation settings in views and views displays #3911

Open
joeparsons opened this issue Nov 22, 2024 · 0 comments
Open

Audit argument validation settings in views and views displays #3911

joeparsons opened this issue Nov 22, 2024 · 0 comments
Labels
enhancement New feature or request spike Research required task Work that doesn't always require a pull request.

Comments

@joeparsons
Copy link
Member

joeparsons commented Nov 22, 2024

Motivation

While reviewing #3884 we noticed that the past events view display that we were adding no results text for is configured to hide view results if argument values do not validate (inherited from master display settings) which was somewhat confusing in the context of testing the view no results behavior.

Proposed Resolution

We decided in our 2024-11-22 meeting that we ought to audit all of our views and views displays that accept arguments to see whether our argument validation settings are consistent and/or whether we want to make any changes to how we handle argument validation in our views.

@joeparsons joeparsons added enhancement New feature or request spike Research required task Work that doesn't always require a pull request. labels Nov 22, 2024
@BaoNguyen09 BaoNguyen09 self-assigned this Nov 22, 2024
@BaoNguyen09 BaoNguyen09 removed their assignment Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request spike Research required task Work that doesn't always require a pull request.
Projects
None yet
Development

No branches or pull requests

2 participants