Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adopt semantic highlighting #94

Closed
aeschli opened this issue Apr 23, 2020 · 3 comments · May be fixed by #110
Closed

Adopt semantic highlighting #94

aeschli opened this issue Apr 23, 2020 · 3 comments · May be fixed by #110

Comments

@aeschli
Copy link

aeschli commented Apr 23, 2020

Since 1.43, VSCode themes can take advantage of semantic highlighting.

Every theme controls whether semantic tokens are enabled. So far, only built-in themes have it enabled and I filed this issue to ask you to opt-in for the ayu theme as well.

Adoption is easy and there are new cool styling possibilities.

To turn on semantic highlighting for a theme, all you have to do is put
"semanticHighlighting": true
in the theme's definition file.

There's a good chance that no further change to the theme is needed (thanks to a default mapping from semantic tokens to TextMate scopes (if not, I'd be interested to know, so I can improve the defaults further)).

But, more interestingly, themes can tune and go wild by defining new styling rules against the semantic tokens:

"semanticTokenColors": {
    "variable.readonly": "#ff0000", 
    "parameter": { "fontStyle": "underline" },
    "*.declaration:java": { "fontStyle": "bold" }
} 

Check out our Semantic Highlighting Wiki and the Semantic Highlighting Guide for more details and feel free to ping me in this issue if I can help.

Thanks for the great work and looking forward to semantic highlighting in your theme.

@thisVioletHydra
Copy link

true

@dempfi
Copy link
Member

dempfi commented Jun 16, 2020

I'll look into this, can't promise much though

@dempfi
Copy link
Member

dempfi commented Sep 2, 2021

Released in v1 colors. No italics or bolds tho. Not sure how to handle them in the best manner. Feel free to reopen if you have an idea

@dempfi dempfi closed this as completed Sep 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants