-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[npm-installer] avoid sorting package.json and npm-shrinkwrap.json #991
Labels
Comments
Oh also node_modules is in .gitignore but in localdev you can create it and the template system I think will gobble it up and we should prevent that. I think just add a continue here if the dir's name is cargo-dist/cargo-dist/src/backend/templates.rs Lines 323 to 335 in e64776d
|
No it super does lmao. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This isn't a big deal but it's ugly.
Serde is auto-sorting them, when really we'd like to keep them in the same order they're checked in. I'm not sure if this is a "don't use serde" (is there a "json_edit" library equivalent to toml_edit? or "find the right flags for serde" or what.
cargo-dist/cargo-dist/src/backend/installer/npm.rs
Line 185 in e64776d
The text was updated successfully, but these errors were encountered: