Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Improved Support/Documentation for PipelineModel #143

Open
jfelectron opened this issue Jun 14, 2021 · 0 comments
Open
Labels
documentation Improvements or additions to documentation

Comments

@jfelectron
Copy link

While an example includes use of PipelineModel: https://github.com/aws/aws-step-functions-data-science-sdk-python/blob/main/src/stepfunctions/template/pipeline/inference.py#L128

This is a no-op: https://github.com/aws/aws-step-functions-data-science-sdk-python/blob/main/src/stepfunctions/template/pipeline/inference.py#L142

Setting the parameters property results in no changes to the CreateModel API call.
Instead, this method should be called: https://github.com/aws/aws-step-functions-data-science-sdk-python/blob/master/src/stepfunctions/steps/states.py#L201

which performs the desired update: self.fields[Field.Parameters.value] = params

Overall, while the example should likely be updated and documentation provided on use of PipelineModel, this method of parameter updating feels like a workaround. Ideally, ModelStep could take PipelineModel as input.

@shivlaks shivlaks added the documentation Improvements or additions to documentation label Sep 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

2 participants