Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get_bucket_policy in 1.52.1 results in Seahorse::Client::NetworkingError Empty or incomplete response body #3043

Closed
carolinebeauchamp opened this issue Jun 12, 2024 · 5 comments
Labels
bug This issue is a bug. investigating Issue is being investigated

Comments

@carolinebeauchamp
Copy link

Describe the bug

My test scripts were failing, with a seahorse networking error when the same scripts worked a few weeks ago.
The offending method is: get_bucket_policy. Reverted back to 1.51.0 and it worked.
D, [2024-06-12T16:15:55.573885 #88512] DEBUG -- : [Aws::S3::Client 500 2.461562 3 retries] get_bucket_policy(bucket:"examplebucket") Seahorse::Client::NetworkingError Empty or incomplete response body

Expected Behavior

Expected it to get the bucket policy without error

Current Behavior

Calling get_bucket_policy results in the following error
D, [2024-06-12T16:15:55.573885 #88512] DEBUG -- : [Aws::S3::Client 500 2.461562 3 retries] get_bucket_policy(bucket:"examplebucket") Seahorse::Client::NetworkingError Empty or incomplete response body

Reproduction Steps

test script


require 'aws-sdk-s3'
require 'logger'
logger = Logger.new(STDOUT)
client = Aws::S3::Client.new(  logger: logger,
                               log_level: :debug,
                               region: "<bucketregion>"
)

resp = client.get_bucket_policy({
                                   bucket: "examplebucket",
                                 })

puts resp.to_h```

### Possible Solution

This PR https://github.com/aws/aws-sdk-ruby/pull/3040 has made changes in how responses are handled, and may have introduced something which breaks the response from get_bucket_policy

### Additional Information/Context

_No response_

### Gem name ('aws-sdk', 'aws-sdk-resources' or service gems like 'aws-sdk-s3') and its version

aws-sdk-s3

### Environment details (Version of Ruby, OS environment)

ruby 3.2 on MacOS and Debian ruby container
@carolinebeauchamp carolinebeauchamp added bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. labels Jun 12, 2024
@alextwoods alextwoods added investigating Issue is being investigated and removed needs-triage This issue or PR still needs to be triaged. labels Jun 12, 2024
@alextwoods
Copy link
Contributor

Sorry you're running into this. I was able to reproduce and agree it looks like #3040 may have broken this. I'm investigating a fix now.

@mullermp
Copy link
Contributor

Oh. I see the issue. The body in this case is json, so it fails the XML check (but it has members in body). I'm sorry.

@alextwoods
Copy link
Contributor

We've reverted #3040 for now which should resolve this issue. Should be released today.

Copy link

This issue is now closed. Comments on closed issues are hard for our team to see.
If you need more assistance, please open a new issue that references this one.

@alextwoods
Copy link
Contributor

We are releasing a new fix #3046 which should also correctly handle this case and will be released today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue is a bug. investigating Issue is being investigated
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants