Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(aws-s3-deployment): Switch Lambda architecture to ARM_64 #29996

Open
1 of 2 tasks
eruvanos opened this issue Apr 29, 2024 · 5 comments · May be fixed by #30042
Open
1 of 2 tasks

(aws-s3-deployment): Switch Lambda architecture to ARM_64 #29996

eruvanos opened this issue Apr 29, 2024 · 5 comments · May be fixed by #30042
Labels
@aws-cdk/aws-s3-deployment effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2

Comments

@eruvanos
Copy link

Describe the feature

To reduce costs and improve sustainability, it would be great to switch CDKBucketDeployment Lambda to ARM_64.

Use Case

Reduced costs.

Proposed Solution

The code looks compatible to ARM_64, switching architecture should be enough.

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

CDK version used

2.102.0

Environment details (OS name and version, etc.)

independent

@eruvanos eruvanos added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Apr 29, 2024
@pahud
Copy link
Contributor

pahud commented Apr 29, 2024

Make perfect sense to me. Welcome to submit a PR. Thank you.

@pahud pahud added p2 effort/small Small work item – less than a day of effort and removed needs-triage This issue or PR still needs to be triaged. labels Apr 29, 2024
@tmokmss
Copy link
Contributor

tmokmss commented May 4, 2024

Is Graviton Lambda available in all the regions and partitions? I could not find relevant coverage data.

@eruvanos
Copy link
Author

eruvanos commented May 4, 2024

@tmokmss That is a good question, did not think about that. I will check, otherwise we would have to introduce a property.

@nmussy
Copy link
Contributor

nmussy commented May 6, 2024

The documentation states that we should be using the pricing region dropdown to get the ARM availability. It seems to be globally available as of today, comparing the dropdown options with a browser inspector, they both have the following 31 regions, including Gov:

us-east-1
us-east-2
us-west-1
us-west-2
af-south-1
ap-east-1
ap-south-2
ap-southeast-3
ap-southeast-4
ap-south-1
ap-northeast-3
ap-northeast-2
ap-southeast-1
ap-southeast-2
ap-northeast-1
ca-central-1
ca-west-1
eu-central-1
eu-west-1
eu-west-2
eu-south-1
eu-west-3
eu-south-2
eu-north-1
eu-central-2
il-central-1
me-south-1
me-central-1
sa-east-1
us-gov-east-1
us-gov-west-1

The CN regions are not included, but they also both seem to support the ARM arch, see pricing.

It should also be safe to assume newly introduced regions will get this feature, given ca-west-1 is the latest release. I don't think this is a concern, but good call @tmokmss

@daschaa
Copy link
Contributor

daschaa commented May 13, 2024

The linked PR looks good imo.
Does this change need an entry in the README or can the exemption request be approved? I think the pr-linter still marks the pull request as "not ready".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-s3-deployment effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants