Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Question] Property case? #206

Open
msummers-nr opened this issue Aug 24, 2022 · 1 comment
Open

[Question] Property case? #206

msummers-nr opened this issue Aug 24, 2022 · 1 comment

Comments

@msummers-nr
Copy link
Contributor

To avoid a lot of copying due to downstream requirements my model uses two properties that begin with lower case letters and gets these two messages from validate

CloudFormation properties don't usually start with lowercase letters: key
CloudFormation properties don't usually start with lowercase letters: values

My contract tests fail in resource_client.py with (my logging)

WARNING  rpdk.core.contract.resource_client:resource_client.py:431 compare_collection: inputs:  [{'Key': 'Key1', 'Values': ['Key1-Value1', 'Key1-Value2']}]
WARNING  rpdk.core.contract.resource_client:resource_client.py:432 compare_collection: outputs: [{'key': 'Key1', 'values': ['Key1-Value1', 'Key1-Value2']}]

With what I'm guessing is a mismatch on the key case difference.

Are properties required to begin with an upper case letter? If so shouldn't validate fail? If not then what is changing the key case? (If lower case is valid the Go model generator should note this in the json tag).

Thanks.

@kddejong
Copy link
Contributor

Its not a requirement but a convention. #186

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants