Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Liveness - Warnings showing when installing liveness package #5123

Open
4 tasks done
reesscot opened this issue Apr 2, 2024 · 2 comments
Open
4 tasks done

[Bug] Liveness - Warnings showing when installing liveness package #5123

reesscot opened this issue Apr 2, 2024 · 2 comments
Labels
bug Something isn't working Liveness

Comments

@reesscot
Copy link
Contributor

reesscot commented Apr 2, 2024

Before creating a new issue, please confirm:

On which framework/platform are you having an issue?

React

Which UI component?

Liveness

How is your app built?

N/A

What browsers are you seeing the problem on?

No response

Which region are you seeing the problem in?

No response

Please describe your bug.

I'm seeing a console warning for @tensorflow/tfjs-backend-webgl when installing Amplify Liveness @aws-amplify/ui-react-liveness package

➜  test-amplify npm install @aws-amplify/ui-react aws-amplify @aws-amplify/ui-react-liveness
npm WARN ERESOLVE overriding peer dependency
npm WARN While resolving: @tensorflow/[email protected]
npm WARN Found: @tensorflow/[email protected]
npm WARN node_modules/@tensorflow/tfjs-core
npm WARN   @tensorflow/tfjs-core@"4.11.0" from @aws-amplify/[email protected]
npm WARN   node_modules/@aws-amplify/ui-react-liveness
npm WARN     @aws-amplify/ui-react-liveness@"^3.0.16" from the root project
npm WARN   4 more (@tensorflow-models/face-detection, ...)
npm WARN
npm WARN Could not resolve dependency:
npm WARN peer @tensorflow/tfjs-core@"4.17.0" from @tensorflow/[email protected]
npm WARN node_modules/@tensorflow/tfjs-backend-webgl
npm WARN   peer @tensorflow/tfjs-backend-webgl@"^4.4.0" from @tensorflow-models/[email protected]
npm WARN   node_modules/@tensorflow-models/face-detection
npm WARN
npm WARN Conflicting peer dependency: @tensorflow/[email protected]
npm WARN node_modules/@tensorflow/tfjs-core
npm WARN   peer @tensorflow/tfjs-core@"4.17.0" from @tensorflow/[email protected]
npm WARN   node_modules/@tensorflow/tfjs-backend-webgl
npm WARN     peer @tensorflow/tfjs-backend-webgl@"^4.4.0" from @tensorflow-models/[email protected]
npm WARN     node_modules/@tensorflow-models/face-detection
npm WARN ERESOLVE overriding peer dependency
npm WARN While resolving: @tensorflow/[email protected]
npm WARN Found: @tensorflow/[email protected]
npm WARN node_modules/@tensorflow/tfjs-core
npm WARN   @tensorflow/tfjs-core@"4.11.0" from @aws-amplify/[email protected]
npm WARN   node_modules/@aws-amplify/ui-react-liveness
npm WARN     @aws-amplify/ui-react-liveness@"^3.0.16" from the root project
npm WARN   4 more (@tensorflow-models/face-detection, ...)
npm WARN
npm WARN Could not resolve dependency:
npm WARN peer @tensorflow/tfjs-core@"4.17.0" from @tensorflow/[email protected]
npm WARN node_modules/@tensorflow/tfjs-backend-webgl/node_modules/@tensorflow/tfjs-backend-cpu
npm WARN   @tensorflow/tfjs-backend-cpu@"4.17.0" from @tensorflow/[email protected]
npm WARN   node_modules/@tensorflow/tfjs-backend-webgl
npm WARN
npm WARN Conflicting peer dependency: @tensorflow/[email protected]
npm WARN node_modules/@tensorflow/tfjs-core
npm WARN   peer @tensorflow/tfjs-core@"4.17.0" from @tensorflow/[email protected]
npm WARN   node_modules/@tensorflow/tfjs-backend-webgl/node_modules/@tensorflow/tfjs-backend-cpu
npm WARN     @tensorflow/tfjs-backend-cpu@"4.17.0" from @tensorflow/[email protected]
npm WARN     node_modules/@tensorflow/tfjs-backend-webgl

What's the expected behaviour?

No warning when installing package

Help us reproduce the bug!

See above

Code Snippet

// Put your code below this line.

Console log output

No response

Additional information and screenshots

No response

@github-actions github-actions bot added the pending-triage Issue is pending triage label Apr 2, 2024
@jeziellago
Copy link

Hello @reesscot

I'm facing this issue. When I add "@tensorflow/tfjs-core": "^4.17.0" all warnings are solved, but I'm not sure if in that way the amplify would override and use v4.17 instead of 4.11.

@reesscot
Copy link
Contributor Author

reesscot commented Apr 4, 2024

Hi @jeziellago,

The Liveness component has not been tested with @tensorflow/tfjs-core version 4.17.0, so I would recommend continuing to use 4.11.0. If you're using npm, you can use the following override to get rid of the warning:

  "overrides": {
    "@tensorflow/tfjs-core": "4.11.0"
  }

My research shows that the @tensorflow-models/face-detection has a peerDependency on @tensorflow/tfjs-backend-webgl that allows any minor version above 4.4.0. Thus it seems that npm is then installing the latest version of @tensorflow/tfjs-backend-webgl which then requires @tensorflow/tfjs-core version 4.17.0, which causes the warning.

Liveness does not use @tensorflow/tfjs-backend-webgl, so you can safely ignore the warning. I doublechecked what is installed in node_modules by npm when seeing the warning, and all @tensorflow packages other than the unused @tensorflow/tfjs-backend-webgl are correctly showing as 4.11.0.

@reesscot reesscot added Liveness needs-discussion An issue or a feature-request that needs-discussion internally or on the discussion tab and removed pending-triage Issue is pending triage labels Apr 4, 2024
@reesscot reesscot added being-investigated An issue or a feature-request is being investigated bug Something isn't working and removed being-investigated An issue or a feature-request is being investigated needs-discussion An issue or a feature-request that needs-discussion internally or on the discussion tab labels Apr 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Liveness
Projects
None yet
Development

No branches or pull requests

2 participants