-
Notifications
You must be signed in to change notification settings - Fork 253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FR: Add support for Angular Change detection and "OnPush" mode #4899
Labels
Angular
An issue or a feature-request for Angular platform
Authenticator
An issue or a feature-request for an Authenticator UI Component
feature-request
Request a new feature
Comments
ioanabrooks
added
bug
Something isn't working
Angular
An issue or a feature-request for Angular platform
Authenticator
An issue or a feature-request for an Authenticator UI Component
and removed
pending-triage
Issue is pending triage
labels
Jan 11, 2024
@QuentinFchx Thank you for reporting this issue, we are looking into it. |
esauerbo
added
feature-request
Request a new feature
and removed
bug
Something isn't working
labels
Jan 19, 2024
Hi @QuentinFchx, I'm changing this to a feature request because our Authenticator component currently isn't designed to support the I'll also add a note of this to our docs site to avoid future confusion. |
calebpollman
changed the title
Change detection issues with angular's authenticator component and "OnPush" mode
FR: Add support for Angular Change detection and "OnPush" mode
Jan 23, 2024
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Angular
An issue or a feature-request for Angular platform
Authenticator
An issue or a feature-request for an Authenticator UI Component
feature-request
Request a new feature
Before creating a new issue, please confirm:
On which framework/platform are you having an issue?
Angular
Which UI component?
Authenticator
How is your app built?
angular cli (v15) / Node v18.15.0
What browsers are you seeing the problem on?
Firefox, Safari
Which region are you seeing the problem in?
eu-west-1
Please describe your bug.
When using the
amplify-authenticator
component inside a component withChangeDetectionStrategy.OnPush
, nothing is rendered.What's the expected behaviour?
The
amplify-authenticator
component should take care of change detection on its own.Help us reproduce the bug!
I've setup a sample repository : https://github.com/QuentinFchx/amplify-ui-change-detection
When you serve the project, you should see a blank page : the
amplify-authenticator
is not rendered.As a workaround, you can uncomment the following lines at https://github.com/QuentinFchx/amplify-ui-change-detection/blob/main/src/app/app.component.ts#L24
AFAIK, the issue seems to come from https://github.com/aws-amplify/amplify-ui/blob/main/packages/angular/projects/ui-angular/src/lib/components/authenticator/components/authenticator/authenticator.component.ts#L89.
I'm not sure what is the purpose of the
hubSubject
, but the callback is never called, thus :detectChanges
in the callback is never calledisHandlingHubEvent
is never set totrue
, thus thedetectChanges
of theauthenticator
subscription (a few lines below) is never calledCode Snippet
No response
Console log output
No response
Additional information and screenshots
No response
The text was updated successfully, but these errors were encountered: