-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Error 500 with Next 13.2: pnpm symlinks breaking changes #3467
Comments
We are having the same 500 error since yesterday for different next releases as you can see at #3466. In our case we are using yarn, still same error. |
Hi @Lezzio 👋🏽 thanks for raising this issue. Please set |
Hi @hloriii, that's the fix we figured out. It does work thanks 🙂 However, is it normal for pnpm symlinks to be broken with amplify all of sudden and is it going to be addressed ? :) |
|
This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Before opening, please confirm:
App Id
dq7klsyx8y65h
AWS Region
us-east-1
Amplify Hosting feature
Frontend builds
Describe the bug
Our production application stopped working. The provision, build, test and deploy would still pass and work fine. However, when accessing the domain all the users would run into an HTTP Error 500.
After intensive efforts and investigation we figured out that the error comes from our package manager pnpm. We would use the default node linker "isolated" which describes as followed:
isolated: dependencies are symlinked from a virtual store at node_modules/.pnpm.
Without any warning or notice it seems like Amplify stopped supporting symlinks the way they are used and created by pnpm (as per the logs).
We came up with a hot fix, using another node linker, the hoisted one:
hoisted: a flat node_modules without symlinks is created. Same as the node_modules created by npm or Yarn Classic. One of Yarn's libraries is used for hoisting, when this setting is used.
Apparently some serverless providers don't support symlinks. Our questions are:
Expected behavior
We expect symlinks to keep working the way they have been so far. Therefore the node linker isolated of pnpm shouldn't cause unnoticed production issues.
Reproduction steps
Build Settings
Log output
Additional information
We're using a NX monorepo with the following structure:
root
- frontend
--- app
--- backoffice
--- shared
--- public-portal
The following amplify app and build specs are to build and deploy the public-portal project.
We use pnpm package defined as followed:
"package": "nx run-many --target=package --all --parallel=4",
Because we have dependencies between our projects.
The text was updated successfully, but these errors were encountered: