Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove uppercase enforcement of environment variables #67

Open
pcassaretto-cmc opened this issue Dec 21, 2023 · 1 comment
Open

Remove uppercase enforcement of environment variables #67

pcassaretto-cmc opened this issue Dec 21, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@pcassaretto-cmc
Copy link

Currently environment vars must be uppercase, which prevents us from populating terraform input variables directly with this action. For example, we cannot do TF_VAR_secret_1 directly with this action and then need an intermediate action to take this output and set the correct terraform environment variable.

I think this should be allowed given the enormous popularity of terraform. Can't see any documented reasoning why you force the name to uppercase here https://github.com/aws-actions/aws-secretsmanager-get-secrets/blob/main/src/utils.ts#L189C54-L189C65

@jbct
Copy link

jbct commented Feb 12, 2024

Thank you for the request, we will look into this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants