Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass environment variables when render task definition #112

Closed
dspv opened this issue Jun 28, 2021 · 3 comments
Closed

Pass environment variables when render task definition #112

dspv opened this issue Jun 28, 2021 · 3 comments
Assignees
@paragbhingre
Labels
feature-request A feature should be added or improved. Investigating

Comments

@dspv
Copy link

dspv commented Jun 28, 2021

Would be great to have the ability to change environment variables when rending a new task definition. I cannot find any other chance how to do it :)
@utkarshcmu
Copy link

+1

@paragbhingre paragbhingre self-assigned this Jul 2, 2021
@paragbhingre paragbhingre added Investigating feature-request A feature should be added or improved. labels Jul 2, 2021
@Misterio77
Copy link
Contributor

Misterio77 commented Jul 5, 2021 •
edited

I had this same need and tried to get it working.

WIP, still testing: https://github.com/Misterio77/amazon-ecs-render-task-definition

EDIT: Seems to work okay, working on getting test coverage for the errors now, just set a PR up

@Misterio77 Misterio77 mentioned this issue Jul 5, 2021
Merged
@amazreech
Copy link
Contributor

Closing older Issue. This should be supported as part of PR114

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@paragbhingre paragbhingre

Labels
feature-request A feature should be added or improved. Investigating
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@utkarshcmu @Misterio77 @paragbhingre @dspv @amazreech and others