Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Track horizontal scroll offset #2

Open
aweary opened this issue Mar 17, 2017 · 1 comment
Open

Track horizontal scroll offset #2

aweary opened this issue Mar 17, 2017 · 1 comment
Labels
enhancement good first bug help wanted

Comments

@aweary
Copy link
Owner

aweary commented Mar 17, 2017

We already track the vertical offset (pageYOffset) so the perimeter is calculated correctly on scroll (and if the component mounts on a page that is already scrolled).

Horizontal scroll is less common, but still it's good idea to support it nonetheless.
@aweary aweary changed the title Track horizontal offset Track horizontal scroll offset Mar 17, 2017
@istarkov
Copy link
Contributor

Seems like pageYOffset is not finished, It looks like you need to recalculate initialOffset here

@istarkov istarkov mentioned this issue Mar 17, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement good first bug help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@istarkov @aweary