-
-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
De-couple commit tagging from GitHub release function #39
Comments
Hi Justin, yes I think that this would be an improvement to some extend, but on the other hand it will make things more complicated as well. Some rough thoughts (not necessarily on autopub or kagi itself, but just so you see where I am coming from):
|
Current Flow
The current flow looks something like:
autopub prepare
: Increment version number, append to CHANGELOG, etc.autopub build
: Build the packageautopub commit
:git commit
the changes from the first stepautopub githubrelease
:git tag
and publish release to GitHub (single step)autopub publish
: Publish package to PyPIThe reason for this order is that the
autopub githubrelease
step needs both the built package as well as the Git tag.Issue
Let's say you want to build the package after the commit has been tagged. Since the package must be built before it is handed to GitHub release process, there is currently no easy way to do things in this order in an AutoPub context because the
autopub githubrelease
step performs both tagging and releasing in a single step.Proposal
If the
git tag
step were to be moved into a separate function, along with a corresponding new commandautopub tag
, then an alternative flow supporting the above use case could look something like:autopub prepare
: Increment version number, append to CHANGELOG, etc.autopub commit
:git commit
the changes from the first stepautopub tag
:git tag
the above commit, with tag as return valueautopub build
: Build the packageautopub githubrelease --tag 4.9
: Pass tag return value to GitHub release functionautopub publish
: Publish package to PyPI(If no
--tag
flag is passed toautopub githubrelease
, then that step would continue to function as before, with tag+release performed in a single step, for backwards compatibility for folks who currently expectautopub githubrelease
to do what it currently does.)The text was updated successfully, but these errors were encountered: