Version 1 #31
Version 1 #31
Conversation
| @@ -0,0 +1,67 @@ | |||
| from pathlib import Path | |||
There was a problem hiding this comment.
I'll move these classes into different files when we agree on the overall architecture :)
autopub/cli/__init__.py
Outdated
| @app.command() | ||
| def build(): | ||
| print("building") | ||
|
|
||
|
|
||
| @app.command() | ||
| def publish(): | ||
| """ | ||
| 1. commit | ||
| 2. release | ||
| 3. push on pypi or similar | ||
| """ | ||
| print("publishing") |
There was a problem hiding this comment.
Feel free to ignore these, I added when I was testing typer out 😊
|
Nice work, Patrick! This seems like an excellent start to me, so I say continue along this path and see where it leads. Well done! 👏 |
|
Hey Patrick! Great to see you at PyCon Italia. Some folks at the DjangoCon EU sprints and I are working on improving Kagi, particularly as it relates to CI and release automation. There's already a pull request there that landed today to add support for PyPI’s new Trusted Publisher feature, and there has been discussion of migrating Kagi from Poetry to Hatchling + PDM-or-Hatch. A lot of these changes seem like a good fit as potential AutoPub plugins. 😊 So… I just thought I'd check in and see when you might be able to make some time to move this modularized AutoPub endeavor forward. What do you think? |
|
@justinmayer being realistic I won't have a lot of time in the next two weeks unfortunately :( I also really need this but I'm struggling a bit to prioritise it, hopefully after the GitHub accelerator program I'll have time. But if there's anyone willing to work on this, then I'd be happy to give the PR to them 😊 |
|
@justinmayer I'm going to do a pair programming session with @bellini666 on this next week! |
I should make this better, but for now it is fine
This PR changes the whole structure of autopub based on what we discusses in #30.
There's a new CLI (powered by typer and rich) that's going to be the frontend for the
Autopubclass. TheCLIwill only get input and display output, all the work is going to be done by theAutopubclass.This is an initial POC, I want to get some feedback on how it looks and especially how the plugin system works. I intentionally didn't spend too much time on it.
The PR implements only the
checkcommand, which you can test by doingpoetry run autopub check.For this command the ideas is that we can have plugins that can add additional validation and also perform actions when the validation fails or passes[1].
[1] this is what we do for Strawberry, we send a GitHub comment with the information about the release.
TODOs
Closes #30