Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maintenance of autolab.rake #2117

Open
damianhxy opened this issue Mar 11, 2024 · 0 comments
Open

Maintenance of autolab.rake #2117

damianhxy opened this issue Mar 11, 2024 · 0 comments

Comments

@damianhxy
Copy link
Member

Current autolab.rake file has several issues

  • It populates fake submissions (load_submissions_for) with old submission path
    • Should update s.filename to "#{i.to_s}_#{a.handin_filename}" and submission_path to File.join(assessment_handin_dir, user.email, s.filename)
  • delete_course (called by depopulate task) uses removed method File.exists?, should use File.exist? instead
  • populate task isn't idempotent, will fail on future runs due to e.g. existing users
  • Minor style issues, e.g. if User.where( ... ).first could be replaced with if User.exists?( ... )
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant