sidecar swallows errors

[JeroenVinke]

Like @Thanood suggested, sidecar is the cause of some errors being swalled in the sample app.

[adriatic]

How is this conclusion verified?

[JeroenVinke]

I forgot to declare a variable in our generateBindables decorator, and I didn't get an error. After disabling sidecar the error became visible, and after enabling sidecar the error disappeared again.

[adriatic]

This means a bug in browser-sync or higher up from there - as having an app running in iframe should not cause such effects.

Conclusion: get rid of side-car - the sooner, the better. Otherwise we could have a nightmare tracing down bugs reported by bridge users.

[JeroenVinke]

Actually, this bug is only swallowing errors in our sample app, the plugin users should be fine. I only created this issue so that it can be investigated further, so I still have hope

[adriatic]

Actually, this bug is only swallowing errors in our sample app

I believe that you knew that I know that, right :-)

[Thanood]

Just thinking..

These are all unresolved promise rejections, right? Bluebird has a feature which can catch these globally (at least they say so). I'm not sure but sidecar may use bluebird. Their master branch has bluebird commented but what if the dist version still has it in?

There certainly is a part of sidecar which doesn't run in an iframe. That is at least the part which creates that iframe and attaches it onto a container element. Now if that part happens to catch promise rejections...

[JeroenVinke]

Hmm, in the Gitter sidecar source code I see they use es6-promise.

which has an issue with not throwing unhandled exceptions

stefanpenner/es6-promise#70

[Thanood]

You're right.. I had too many "if"s in my thoughts anyway. Bluebird being commented doesn't necessarily mean anything.

There are a lot of "swallowing" issues mentioned in the issue you linked.

[JeroenVinke]

removed gitter sidecar in 9f80976