Possible confusion about the two Change speed dialogs

[DavidBailes]

There are now (or will be very very soon) two change speed dialogs. A new dialog which acts non-destructively on a clip, and the old one for an effect which acts destructively on the selected audio.
The new dialog changes speed whilst preserving pitch, whereas the old dialog doesn't preserve pitch.
Users are used to the idea that "changing speed" doesn't preserve pitch, but there is nothing in the new dialog, or the commands that open it to suggest that pitch is preserved.
Wouldn't it be helpful to the user to make that explicit in some way? - text in the dialog, dialog title, etc?

[LWinterberg]

I'm not a big fan of using the near-synonymous words speed and tempo to distinguish between whether or not pitch will also be affected.

How about we rename the "Change Speed" effect to "Change Speed and Pitch", so it's clear that both parts are affected? cc @DilsonsPickles @Tantacrul @petersampsonaudacity

(to be clear, we're talking about this guy:

)

[Tantacrul]

Works for me.

[DavidBailes]

Works for me.

and for me.

[crsib]

What about Effect > Pitch and Tempo > Change Speed...?

[crsib]

I mean, there are both "Change Speed" and "Change Pitch"

[LWinterberg]

that's the exact thing I'm renaming :)

[petersampsonaudacity]

@LWinterberg @crsib

I have placed P1s in the Manual for this - but is not yet in master for 3.4.0

[petersampsonaudacity]

I have updated the Manual for this