Check for install success?

[ragaskar]

I'm kind of a weird use case -- I have ditched OMV, but I really liked this script, so I'm using it with the snapraid install running on my proxmox host. It seems like it will work fine? The only OMV specific bits at first glance appear to be around auto-locating a snapraid config, but I'm happy to just specify an explicit path.

That said, I ran into a fun problem with the email reports (which are awesome!):

I'm running this script as root, because I'm a terrible person, and am missing a few dependencies (python-markdown and jq).
In theory these get installed by the script if missing, but in my case, they don't, since my root user doesn't have sudo on their path, so the install quietly fails (and presumably, subsequently prevents the email body from rendering), despite what the log output claims.

(It took me a silly amount of time to figure out that this was my problem, because I kept misinterpreting the install check as looking for presence of an "ok installed" string vs. absence -- by grep -c counting lines)

Anyhow, not sure if you care to handle this case at all, but, if you did, it would be neat if the install itself was wrapped in an if such that a failed dep install at least logged (and maybe exited depending on how problematic the missing dep is?). Line in question is this one

Thanks for this script! I found it really useful -- a nice automation like this seems like solves the most complicated part of running snapraid.

[auanasgheps]

Hi there,

Thanks for your kind message. It's great to hear this scripts really helps people.

Sure, I'll implement a proper check for dependencies and exit if needed.

By the way, apparently I'm a terrible person too since I run the script as root too :)