Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Visual Enhancements Needed for Gallery Block on Posts/Pages #18

Open
alexdeborba opened this issue Oct 20, 2023 · 0 comments
Open

Visual Enhancements Needed for Gallery Block on Posts/Pages #18

alexdeborba opened this issue Oct 20, 2023 · 0 comments
Assignees
Labels
[Component] Block Patterns Issues related to pre-designed content sections. [Component] theme.json Issues related to the theme.json configuration file. [Status] Help Wanted Seeking community assistance on specific issues.

Comments

@alexdeborba
Copy link
Collaborator

Description:

The Gallery Block in the theme lacks consistent padding at the top, similar to the previously noted concerns with the Image Block Issue #15. The desired padding adjustments set in the theme.json have not been effectively reflected within the theme. To temporarily address this, changes have been made directly to the style.css file.

1. Padding on Top of Gallery Block:

  • The Gallery Block is missing adequate padding at the top. Adding this padding would ensure a clearer separation from preceding content, enhancing both readability and the visual flow of the page.

Step-by-step Reproduction Instructions:

  1. Navigate to a post in the theme that features a Gallery Block.
  2. Examine the space above the Gallery Block, noting the absence of top padding.

Expected Behavior:

The Gallery Block should display with suitable top padding, offering a distinct separation from any content or elements that precede it.

Screenshots:

Screenshot
Backend Preview.

Screenshot
Frontent Preview.

Current Workaround:

Although the goal was to apply this padding through the theme.json, the theme did not adopt these changes. As a provisional measure, the necessary padding adjustments have been incorporated into the style.css file. This is a temporary solution, and the intention is to eventually determine an effective way to integrate this padding adjustment within theme.json and then remove the associated styles from style.css.

Suggested Next Steps:

Investigate the reason for the theme.json not translating the padding styles to the theme. Once a resolution is identified, transition the padding adjustments from style.css to theme.json to maintain best practices and consistency within the theme.

@atmostfear-entertainment atmostfear-entertainment added [Status] Help Wanted Seeking community assistance on specific issues. [Component] Block Patterns Issues related to pre-designed content sections. [Component] theme.json Issues related to the theme.json configuration file. labels Oct 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Component] Block Patterns Issues related to pre-designed content sections. [Component] theme.json Issues related to the theme.json configuration file. [Status] Help Wanted Seeking community assistance on specific issues.
Projects
None yet
Development

No branches or pull requests

3 participants