-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
eslint config references airbnb-base which was not in package.json's devDepencies #3
Comments
Hi, Thanks for checking the script out! If you selected "Yes" for the prompt ''Do you want to setup eslint+prettier?", you should see the following 6 packages added as "devDependencies" : {
...
"eslint-config-airbnb-base": "^14.1.0",
"eslint-config-prettier": "^6.11.0",
"eslint-import-resolver-ember": "0.0.1",
"eslint-plugin-import": "^2.22.0",
"eslint-plugin-prettier": "^3.1.4",
"prettier": "^2.0.5",
...
} The {
...
extends: [
'airbnb-base',
'eslint:recommended',
'plugin:ember/recommended',
'prettier',
],
...
} None of the above changes should be observable if you selected "No" for the aforementioned prompt. Also, if you're using yarn as your package manager, you may get an additional prompt before Hope this helps. |
Ah, OK. Thanks. For what it's worth, I did choose "Yes" for all of the relevant choices. I'm using Yarn but I didn't receive an additional prompt and a few of the devDependencies weren't in package.json. I didn't look into why, but that's where my confusion was coming from. Thanks! |
By default, the installed
.eslintrc.js
referencesairbnb-base
which isn't included.I also noticed the "Installing airbnb config..." message when running the install script (which I assume is unintentional).
The text was updated successfully, but these errors were encountered: