Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sanitize $_SERVER['REQUEST_URI'] #34

Open
tmuras opened this issue Jul 12, 2020 · 0 comments
Open

Sanitize $_SERVER['REQUEST_URI'] #34

tmuras opened this issue Jul 12, 2020 · 0 comments

Comments

@tmuras
Copy link

tmuras commented Jul 12, 2020

$_SERVER['REQUEST_URI'] is used to construct HTML:
https://github.com/at-tools/moodle-block_massaction/blob/master/block_massaction.php#L123

The variable should be sanitized as it potentially allows for injecting HTML there.
REQUEST_URI is normally URL-encoded but that encoding is done by the browser, so it should not be trusted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant