-
-
Notifications
You must be signed in to change notification settings - Fork 185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEATURE] Golang generator should include comments from parameter descriptions #2116
Comments
Welcome to AsyncAPI. Thanks a lot for reporting your first issue. Please check out our contributors guide and the instructions about a basic recommended setup useful for opening a pull request. |
Makes sense, happy to accept PRs 🙏 |
Hey @jonaslagoni, I think this change should apply to all the languages we support, not just Golang |
Feel free to create an issue per language where this is missing (some already have it), or jump straight into a PR @toffee-k21 ✌️ |
What do you mean - per language? I've specified Golang in the title. I can't fix it myself in your code, but it should be very quick for those how know modelina codebase |
We got multiple languages that dont have a preset that include descriptions.
This is the basic recipe:
|
sorry this code doesn't make sense to me at all, I'm from c++/go |
Ok, I've copied and adopted DescriptionPreset.ts from typescript to go, added it to go/presets/index.ts, but it never called and no comments in my generated sources. What should I do to make it work? nothing new in comments, annoying "ResponsePayload represents a ResponsePayload model" still exists, so I assume that my preset even doesn't called. Maybe it is not plugged in inside modelina for golang? |
Why do we need this improvement?
Golang generator should include comments from parameter descriptions
How will this change help?
Golang generator should include comments from parameter descriptions
Screenshots
No response
How could it be implemented/designed?
Golang generator should include comments from parameter descriptions
🚧 Breaking changes
No
👀 Have you checked for similar open issues?
🏢 Have you read the Contributing Guidelines?
Are you willing to work on this issue?
None
The text was updated successfully, but these errors were encountered: