-
-
Notifications
You must be signed in to change notification settings - Fork 185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add loading animation for when playground generate models #1725
Comments
@jonaslagoni working on this |
@jonaslagoni we want to add the loading screen in the output models only or in the whole screen ? |
To me just the output models make sense to me, cause then the user can still change settings and input @devilkiller-ag what do you think? 🤔 |
I also think that showing the loader on the output screen only will make more sense. |
check the PR added the loader in the output screen only |
If no one working on this issue would love to try it out @jonaslagoni @devilkiller-ag |
Hi @ConnectBhawna, you can work on this issue. Make sure to go through #1730 to know the approach of previous PR on this issue. |
Hi @ConnectBhawna, Do you have any updates on this? |
Yeahh almost done, will do the PR by this weekand |
Hi @ConnectBhawna, how's the work going on? Feel free to share if you are facing any issue. |
Hey @devilkiller-ag i want to work on this issue, but I am unable to setup this project, can you help me a little bit ? |
Thnx @devilkiller-ag |
Hey @devilkiller-ag I am attaching a screen recording, can you check it once , as you have not assigned me issue, can I create a PR ? Screencast.from.15-06-24.10.46.05.PM.IST.webm |
@Alokih this looks good to me. You can open a PR so that I can do further checks. |
@devilkiller-ag I just wanted to tell that I have taken help from previous PR which was closed |
@devilkiller-ag getting this error when I ran modelina-website can you please share workaround for this or should I create a issue |
Hi @Girishbari, Did you first build the modelina? First, you must run this command from inside the |
thx, that really worked, I initally ran build command outside of modelina-website folder |
Hey! I would like to work on this issue. Could you please assign me this? @devilkiller-ag |
@Shriya-Chauhan Yeah sure, Go ahead! |
Reason/Context
https://modelina.org/playground
When you change the input, open the playground, or change the settings, the playground need to ask the backend to re-generate the models, and there can be a significant delay here depending on input and latency to the backend server. Therefore I suggest we add a loading screen to the output models view that showcases that it is currently in the process of being generated.
You can find the most relevant code for the playground here: https://github.com/asyncapi/modelina/blob/master/modelina-website/src/components/playground/Playground.tsx
And the output panel can be found here: https://github.com/asyncapi/modelina/blob/master/modelina-website/src/components/playground/OutputNavigation.tsx
The text was updated successfully, but these errors were encountered: