-
-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
conversion to v3 do not preserve strign quotes #197
Comments
it is not only with refs, also |
still relevant cc: @derberg @jonaslagoni |
I think so, yes |
Hey @jonaslagoni , for this bug i have changed the above function to
such that it preserves the double quotes, This is the correct solution right ? |
@ItshMoh whatever works, add a test and see it in action 🙂 |
Hey @jonaslagoni I think this issue is resolved. The asyncapi v3 is already giving $ref in ' ' . Here is the link to output file of conversion of asyncapi from v2 to v3. Here $ref is already in ' ' . But investigating the above issue. I have found out that the async api test file is giving the below error in studio. should i open a issue in studio or is this the error of converter. |
Example reference in single quotes prior v3 -> https://github.com/asyncapi/spec/blob/master/examples/social-media/backend/asyncapi.yaml#L9
After conversion it becomes
../common/servers.yaml#/websiteWebSocketServer
without quotesProblem is that some editors, like Studio for example, interprets
#/websiteWebSocketServer
as a YAML commentcc @magicmatatjahu @jonaslagoni
The text was updated successfully, but these errors were encountered: