Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐁 Provide demo-only hooks for demo switching #96

Open
5 tasks
asvae opened this issue Oct 25, 2021 · 0 comments
Open
5 tasks

🐁 Provide demo-only hooks for demo switching #96

asvae opened this issue Oct 25, 2021 · 0 comments
Labels
feature Useful to end user

Comments

@asvae
Copy link
Owner

asvae commented Oct 25, 2021

There are 2 cases we want to cover with this:

  • We need a hook for comoponent setup (in majority of cases only one hook is needed, as global state will be overriden and we don't need disassembly step).
  • Sometimes disassembly is still important. It might also prevent non destroyed component from erroring out.

Implementation wise

  • We probably want to postpone router navigation until previous page is destroyed, that way onCreate/onDestroy would work just fine.

// Not sure if needed

  • onDemoEnter - should always trigger after onDemoLeave of previously visited component.
  • onDemoLeave
@asvae asvae added the feature Useful to end user label Oct 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Useful to end user
Projects
None yet
Development

No branches or pull requests

1 participant