Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rules UP037 cause autofix error #7102

Closed
qarmin opened this issue Sep 3, 2023 · 1 comment · Fixed by #15337
Closed

Rules UP037 cause autofix error #7102

qarmin opened this issue Sep 3, 2023 · 1 comment · Fixed by #15337
Labels
bug Something isn't working fuzzer Surfaced via fuzzing.

Comments

@qarmin
Copy link

qarmin commented Sep 3, 2023

Ruff 0.0.287 (latest changes from main branch)

ruff  *.py --select UP037 --no-cache --fix

file content(at least simple cpython script shows that this is valid python file):

from __future__ import annotations
class IdentityLinearOperator(ConstantDiagLinearOperator):
    def _mul_matrix(
        other: Union[Float[torch.Tensor, "... #M #N"], Float[LinearOperator, "... #M #N"]],
    ) -> Float[LinearOperator, "... M N"]:
        return other

error

/home/rafal/test/tmp_folder/2589347.py:4:42: UP037 Remove quotes from type annotation
/home/rafal/test/tmp_folder/2589347.py:4:78: UP037 Remove quotes from type annotation
Found 2 errors.

error: Autofix introduced a syntax error. Reverting all changes.

This indicates a bug in `ruff`. If you could open an issue at:

    https://github.com/astral-sh/ruff/issues/new?title=%5BAutofix%20error%5D

...quoting the contents of `/home/rafal/test/tmp_folder/2589347.py`, the rule codes UP037, along with the `pyproject.toml` settings and executed command, we'd be very appreciative!


python_compressed.zip

@zanieb zanieb added the fuzzer Surfaced via fuzzing. label Sep 3, 2023
@charliermarsh charliermarsh added the bug Something isn't working label Sep 3, 2023
@charliermarsh
Copy link
Member

Hah that's a really tricky one. The annotation is valid code (... #M #N), but it ends in a comment, so it's not valid to inline in that position 🤦

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working fuzzer Surfaced via fuzzing.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants