From 551a46d14ebd4a2e03ca04d2e5f92d748c85078f Mon Sep 17 00:00:00 2001
From: Alain Schlesser <alain.schlesser@gmail.com>
Date: Sun, 24 Mar 2019 17:07:25 +0100
Subject: [PATCH] Refactor logic out of view

---
 src/SettingsGeneralService.php | 48 ++++++++++++++++++++++++++++------
 views/setting.php              |  2 +-
 2 files changed, 41 insertions(+), 9 deletions(-)

diff --git a/src/SettingsGeneralService.php b/src/SettingsGeneralService.php
index 435f085..ab04b13 100644
--- a/src/SettingsGeneralService.php
+++ b/src/SettingsGeneralService.php
@@ -37,15 +37,17 @@ public function __construct( ViewFactory $view_factory ) {
 	 * @return void
 	 */
 	public function register(): void {
-		if ( ! isset( $_SERVER[ ASMP::VERSION ] ) ) {
-		// TODO	return;
+		if ( ! $this->has_asmp() ) {
+			return;
 		}
 
-		// TODO
-		$_SERVER[ ASMP::ENDPOINT ] = [ '5.6', '7.0', '7.2' ];
-
-		add_action( 'admin_init', function() {
-			\add_settings_field( 'asmp', esc_html__( 'PHP Versions', 'asmp' ), [ $this, 'render' ], 'general' );
+		\add_action( 'admin_init', function () {
+			\add_settings_field(
+				'asmp',
+				esc_html__( 'PHP Versions', 'asmp' ),
+				[ $this, 'render' ],
+				'general'
+			);
 		} );
 	}
 
@@ -56,7 +58,37 @@ public function register(): void {
 	 */
 	public function render(): void {
 		echo $this->view_factory->create( 'views/setting' )
-		                        ->render();
+		                        ->render( [ 'options' => $this->retrieve_php_version_options() ] );
+	}
+
+	/**
+	 * Check whether ASMP is available.
+	 *
+	 * @return bool Whether ASMP is available.
+	 */
+	private function has_asmp(): bool {
+		return true;
+		// return isset( $_SERVER[ ASMP::VERSION ] );
+	}
+
+	/**
+	 * Get the ASMP endpoint to communimcate with.
+	 *
+	 * @return string ASMP endpoint.
+	 */
+	private function get_endpoint(): string {
+		return '';
+		// return $_SERVER[ ASMP::ENDPOINT ];
+	}
+
+	/**
+	 * Retrieve the available options for the PHP version.
+	 *
+	 * @return array
+	 */
+	private function retrieve_php_version_options() {
+		// TODO
+		return [ '5.6', '7.0', '7.2' ];
 	}
 }
 
diff --git a/views/setting.php b/views/setting.php
index fd1c7d4..ac4d818 100644
--- a/views/setting.php
+++ b/views/setting.php
@@ -1,6 +1,6 @@
 <select id="php_version" name="php_version">
 <?php
-foreach ( $_SERVER[ ASMP\WordPressIntegration\ASMP::ENDPOINT ] as $version ) :
+foreach ( $this->options as $version ) :
 	printf( '<option value="%1$s">%1$s</option>', $version );
 endforeach;
 ?>