-
-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gitlab plugin does not handle subgroups #153
Comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hi,
I'm facing an issue when i get a 404 error whenever i try to create a new scm plugin entry.
The plugin only works with "simple" urls but don't want to work when the repo si within a subgroup in gitlab.
After reviewing the code of https://github.com/ashwanthkumar/gocd-build-github-pull-requests/blob/master/src/main/java/in/ashwanthkumar/gocd/github/provider/gitlab/GitLabProvider.java and
gocd-build-github-pull-requests/src/main/java/in/ashwanthkumar/gocd/github/provider/github/GHUtils.java
Line 24 in 12df905
The plugin currently can only handle urls like these : protocol / host / username / repo seeing the algorithm in the method parseGithubUrl.
But a url like this is a perfectly valid gitlab url : protocol / host / group1/ subgroup1 / subgroup2/ repo
The code could be fixed to try to account for that but why can't we just provide the project id as an additional parameter considering that the Gitlab api client can handle it and that that information is readily available in the gitlab interface ?
I don't know the full consequences of replacing the project url parameter but i think it would be less intrusive to add an optional parameter with the project id.
If i want to make a contribution is there some documentation i could follow since the issue is quite pressing for me?
The text was updated successfully, but these errors were encountered: