Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support asdf install in subdirectories #326

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

support asdf install in subdirectories #326

wants to merge 5 commits into from

Conversation

afirth
Copy link

@afirth afirth commented Jun 17, 2021 •
edited

  • add a new directory option for asdf-install action
  • fix yaml for install action so it's valid

should
/fixes #83
IMO also solves #84 as you can just call it multiple times

Use case: have k8s deploy manifests+tooling living with the code. Don't need to install the dev tooling to deploy it in CI (or locally), and devs don't need to install the deploy tooling just to work with the code (since it automatically deploys on merge).

complete example:

on: push
name: lint
jobs:
  lint:
    name: k8s lint manifests
    runs-on: ubuntu-latest
    strategy:
      matrix:
        include:
          - stage: dev
            cluster: platform-development
          - stage: prod
            cluster: platform-production
    defaults:
      run:
        working-directory: ./deploy
    steps:
      - name: Checkout
        uses: actions/checkout@v2

      - name: Install CD tools from .tool-versions
        if: steps.asdf-cache.outputs.cache-hit != 'true'
        uses: FATMAP/asdf-vm-actions/install@2021-06-16-chdir
        with:
          directory: ./deploy # << :tada: 

      - name: kustomize
        env:
          CLUSTER: ${{ matrix.cluster }}
          STAGE: ${{ matrix.stage }}
        run: |
          kustomize build --load-restrictor=LoadRestrictionsNone clusters/$STAGE/$CLUSTER > ./manifest.yaml

      - name: lint
        uses: instrumenta/kubeval-action@master
        with:
          files: deploy/manifest.yaml

@afirth afirth mentioned this pull request Jun 17, 2021
Merged
@afirth afirth mentioned this pull request Jun 17, 2021
Open
@afirth
Copy link
Author

afirth commented Jun 17, 2021

I cannot get the build output to match exactly. See #325

@afirth
Copy link
Author

afirth commented Jan 5, 2022

is anybody maintaining this repo? If so, would appreciate some guidance in #325 to get this working

@jthegedus jthegedus self-requested a review as a code owner March 9, 2023 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jthegedus jthegedus Awaiting requested review from jthegedus jthegedus is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Install action does not honor working-directory
1 participant
@afirth