Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more locales #2

Open
arthurdenner opened this issue Jul 30, 2018 · 4 comments
Open

Add more locales #2

arthurdenner opened this issue Jul 30, 2018 · 4 comments
Labels
enhancement New feature or request good first issue Good for newcomers Hacktoberfest Opportunity to contribute on the event help wanted Extra attention is needed pinned

Comments

@arthurdenner
Copy link
Owner

arthurdenner commented Jul 30, 2018 •
edited
Loading

馃寛 Feature

We have some locales options, but we can always have more! 馃槃

In order to do this, you should:

馃摑 Clone the English locale and change the texts;
馃攽 Add the locale key to the types;
馃攽 Add the locale key to the Storybook options;
馃帀 Submit a PR with the changes.

If you are not familiar with open-source contributions, checkout this course.
@arthurdenner arthurdenner added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers labels Jul 30, 2018
@arthurdenner arthurdenner added Hacktoberfest Opportunity to contribute on the event enhancement New feature or request and removed enhancement New feature or request labels Oct 10, 2019
@adamxtokyo
Copy link
Contributor

adamxtokyo commented Oct 25, 2019 •
edited
Loading

I'll do the Swedish and Japanese locale 馃憤 馃槃

This was referenced Oct 25, 2019
Merged
Merged
@adamxtokyo
Copy link
Contributor

Done! 馃槃
Double-checked the spelling, ran the tests, and then pushed the changes.
Happy to contribute 馃槍

@Gallevy Gallevy mentioned this issue Nov 9, 2019
Merged
3 tasks
@Cmoen11 Cmoen11 mentioned this issue Jan 13, 2020
Merged
@stale
Copy link

stale bot commented May 9, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label May 9, 2020
@arthurdenner arthurdenner added pinned and removed stale labels May 9, 2020
@unbugged unbugged mentioned this issue Aug 7, 2020
Merged
3 tasks
@Yeongjae-Shin Yeongjae-Shin mentioned this issue Oct 13, 2020
Merged
3 tasks
@Yeongjae-Shin
Copy link
Contributor

I finished translating Korean
Check PR plz 馃槉

@DanielleHuisman DanielleHuisman mentioned this issue Mar 8, 2022
Merged
3 tasks
@arthurdenner arthurdenner mentioned this issue Jul 19, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers Hacktoberfest Opportunity to contribute on the event help wanted Extra attention is needed pinned
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@adamxtokyo @arthurdenner @Yeongjae-Shin